Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Homepage, Profile Manager, Twin and Transfer and Bridge tests #1667

Closed
wants to merge 7 commits into from
Closed

update Homepage, Profile Manager, Twin and Transfer and Bridge tests #1667

wants to merge 7 commits into from

Conversation

A-Harby
Copy link
Contributor

@A-Harby A-Harby commented Dec 12, 2023 •
edited
Loading

Description

Update the test to work on the new dashboard UI; these updates are only done on the homepage, twin, and transfer TFT and bridge pages; the other tests haven't been done yet.

Some tests are still failing, but they are tracked on created issues and will be updated with the coming PR.

@ramezsaeed ramezsaeed mentioned this pull request Dec 17, 2023
Closed
2 tasks
@ramezsaeed ramezsaeed mentioned this pull request Jan 1, 2024
Closed
16 tasks
@A-Harby A-Harby changed the title update homepage, profile manager, twin and transfer tft tests update Homepage, Profile Manager, Twin and Transfer and Bridge tests Jan 4, 2024
@A-Harby A-Harby marked this pull request as ready for review January 4, 2024 09:16
mohamedamer453
mohamedamer453 reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are supposed to be updated for the new dashboard UI however they're still in the old dashboard directory.

packages/dashboard/tests/frontend_selenium/pages/dashboard.py Outdated Show resolved Hide resolved
packages/dashboard/tests/frontend_selenium/pages/dedicate.py Show resolved Hide resolved
packages/dashboard/tests/frontend_selenium/tests/conftest.py Show resolved Hide resolved
@A-Harby
Copy link
Contributor Author

A-Harby commented Jan 9, 2024

These tests are supposed to be updated for the new dashboard UI however they're still in the old dashboard directory.

@mohamedamer453, Indeed, they are. But in this PR, I'm just trying to update the test itself, and in the coming PRs, I'll update the other tests, the documents, and the location.

@A-Harby A-Harby marked this pull request as draft January 10, 2024 12:20
@A-Harby
Copy link
Contributor Author

A-Harby commented Feb 12, 2024

Wip:

  • Working on updating the navigation of the pages to the new order.
  • changing the directory of the tests to the playground directory.
  • Finding another way to fix static waiting from amer comments.

@A-Harby A-Harby marked this pull request as ready for review April 8, 2024 11:21
@A-Harby A-Harby requested a review from samaradel as a code owner April 8, 2024 11:21
@A-Harby A-Harby requested a review from mohamedamer453 April 8, 2024 11:21
@A-Harby A-Harby marked this pull request as draft April 8, 2024 11:24
@A-Harby A-Harby mentioned this pull request Apr 14, 2024
Merged
5 tasks
@A-Harby A-Harby closed this Apr 14, 2024
@AhmedHanafy725 AhmedHanafy725 deleted the development_update_home_twin_transfer_tests branch May 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@khaledyoussef24 khaledyoussef24 Awaiting requested review from khaledyoussef24

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-Harby @mohamedamer453