Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connect dialogue in smaller screens #1671

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix connect dialogue in smaller screens #1671

merged 3 commits into from
Dec 14, 2023

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Dec 12, 2023 •
edited
Loading

Description

  • Fix style on medium screens
  • Fix download buttons style

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

mohamedamer453
mohamedamer453 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • At certain window sizes the separator line will clip the download button.

    image

@AhmedHanafy725 AhmedHanafy725 merged commit b163966 into development Dec 14, 2023
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_fix_profile_style branch December 14, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedamer453 mohamedamer453 mohamedamer453 approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @AhmedHanafy725 @mohamedamer453