Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set nodes count to 0 if there're no nodes to display #1682

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

mohamedamer453
Copy link
Contributor

Description

Fix count if there're no nodes to display in the Nodes table.

Screencast.from.13-12-23.11.25.18.webm

Changes

  • Added a condition to set the nodesCount to 0 if the count is equal to 0.

Related Issues

#1604

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Co-authored-by: Omar Kassem <omarksm09@gmail.com>
@zaelgohary zaelgohary requested a review from 0oM4R December 13, 2023 10:07
@mohamedamer453 mohamedamer453 merged commit 28d6c07 into development Dec 13, 2023
3 checks passed
@mohamedamer453 mohamedamer453 deleted the development_fix_nodes_count branch December 13, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants