Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sorting in farms table #1693

Merged
merged 3 commits into from
Dec 14, 2023
Merged

remove sorting in farms table #1693

merged 3 commits into from
Dec 14, 2023

Conversation

amiraabouhadid
Copy link
Contributor

Description

removed sorting farms table

Changes

  • remove sorting icons on farm ID and name
  • remove sorting functions and types
  • change watcher to update table only on page,size or filter changes

Related Issues

#45

mohamedamer453
mohamedamer453 reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you hover over ID and Name columns they're still highlighted and give the feeling that they're sortable unlike the rest of the columns in that table.

Screencast.from.14-12-23.12.57.23.webm

@AhmedHanafy725 AhmedHanafy725 merged commit d4282b1 into development Dec 14, 2023
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the dev_update_farms_sorting branch December 14, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedamer453 mohamedamer453 mohamedamer453 approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraabouhadid @AhmedHanafy725 @mohamedamer453