Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for activate account button #1697

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

AlaaElattar
Copy link
Contributor

Description

  • It was confusing between Activate Account and Create Account

Changes

  • Added tooltip for Activate Account button.

Related Issues

#1323 (comment)

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Dec 17, 2023

the tooltip doesnt show when i hover over the activate account button
https://www.loom.com/share/f717d12b7f0549f8b3a38620ac42747b?sid=22903ccd-b791-41c9-b358-3fc13a8cbf6c

@AlaaElattar
Copy link
Contributor Author

AlaaElattar commented Dec 17, 2023

the tooltip doesnt show when i hover over the activate account button https://www.loom.com/share/f717d12b7f0549f8b3a38620ac42747b?sid=22903ccd-b791-41c9-b358-3fc13a8cbf6c

It will show when the button is enabled. As long as ur mnemonic is activated, you won't see it.

@AlaaElattar
Copy link
Contributor Author

the tooltip doesnt show when i hover over the activate account button https://www.loom.com/share/f717d12b7f0549f8b3a38620ac42747b?sid=22903ccd-b791-41c9-b358-3fc13a8cbf6c

try with this tourist deal primary faith security mixed exercise keen wisdom quarter deny ramp

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-12-18 13-57-46

@AlaaElattar AlaaElattar merged commit 4ea1e4a into development Dec 18, 2023
3 checks passed
@AlaaElattar AlaaElattar deleted the development_tooltip_activate_account branch December 18, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants