Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flatten vm array to fix sort casuing error in caprover and workers based solutions #1727

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

MohamedElmdary
Copy link
Member

Description

flatten vm array to fix sort casuing error in caprover and workers based solutions

Changes

  • group workers of vms into an array in leader objec

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@AhmedHanafy725
Copy link
Contributor

in case the deployment doesn't have workers, this error happens when trying to click on manage button

image

@MohamedElmdary
Copy link
Member Author

MohamedElmdary commented Dec 19, 2023

in case the deployment doesn't have workers, this error happens when trying to click on manage button

...

fixed

@MohamedElmdary MohamedElmdary merged commit 241491a into development Dec 19, 2023
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_fix_caprover_dialog branch December 19, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants