fix: add limit 1 to validation tries #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedElmdary
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
Mahmoud-Emad,
amiraabouhadid,
Omarabdul3ziz,
AlaaElattar and
0oM4R
as code owners
AhmedHanafy725
approved these changes
Dec 21, 2023
zaelgohary
reviewed
Dec 21, 2023
It should be fine to keep the check as someone might pass a wrong value e.g -1 |
zaelgohary
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working with useAsync I notice that validation is done 3 times (if valid) which not bad in case a user have bad connection but too bad if task takes long time
Changes
limit tries to 1 to validation tasks
Related Issues
Checklist