Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decimal err in dedicated filters #1772

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Fix decimal err in dedicated filters #1772

merged 5 commits into from
Dec 26, 2023

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Dec 21, 2023 •
edited
Loading

Description

  • Used Math.floor with values as Grid Proxy doesn't accept float values
  • Refactored NodesQuery
  • Added filter by total resources in nodes page
  • Fixed formatResources
  • Fixed filter by decimal in nodes & dedicated nodes

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R
Copy link
Contributor

0oM4R commented Dec 24, 2023

Screenshot from 2023-12-24 11-13-58

Ram field does not accept decimal number
and i don't think it's a good idea to use floor, I suggest to use ceil

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Dec 24, 2023 •
edited
Loading

I tried it with exact RAM value but it failed
image
image

@zaelgohary
Copy link
Contributor Author

I tried it with exact RAM value but it failed image image

The value in the table was rounded. Fixed by showing the value without any rounding.

amiraabouhadid
amiraabouhadid approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding it nodes page too
image

@zaelgohary zaelgohary merged commit 5dd1f0d into development Dec 26, 2023
3 checks passed
@zaelgohary zaelgohary deleted the development_fix_dedicated_decimal_err branch December 26, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @0oM4R @amiraabouhadid