Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swap price component #1780

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Fix swap price component #1780

merged 3 commits into from
Dec 26, 2023

Conversation

MohamedElmdary
Copy link
Member

Description

Swap price sometimes show 0

Changes

  • fix: avoid show 0 value for tft price
  • feat: handle error and allow user to reload value if failed 5 times
  • feat: use ordering css instead of rerender component when swapping price

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary
fix: avoid show 0 value for tft price
01da7bd 
- feat: handle error and allow user to reload value if failed 5 times
- feat: use ordering css instead of rerender component when swapping price
@MohamedElmdary MohamedElmdary self-assigned this Dec 24, 2023
amiraabouhadid
amiraabouhadid approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

0oM4R
0oM4R requested changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the price is not accurate
image

Screenshot from 2023-12-26 10-22-10

@MohamedElmdary MohamedElmdary requested a review from 0oM4R December 26, 2023 08:46
@zaelgohary zaelgohary merged commit beca58f into development Dec 26, 2023
3 checks passed
@zaelgohary zaelgohary deleted the development_fix_swap_price branch December 26, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

Assignees

@MohamedElmdary MohamedElmdary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MohamedElmdary @amiraabouhadid @0oM4R @zaelgohary