Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance performance of workloads validating #1810

Merged
merged 4 commits into from
Dec 31, 2023
Merged

Enhance performance of workloads validating #1810

merged 4 commits into from
Dec 31, 2023

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented Dec 27, 2023 •
edited
Loading

Description

Enhance the performance of validating the resource while deploying the workloads

Changes

  • refactor: use Promise.all instead of for await to parallelize execution
  • fix: group all deployments with same nodeId and sum all it's resources before validating

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary MohamedElmdary self-assigned this Dec 27, 2023
@MohamedElmdary MohamedElmdary marked this pull request as draft December 31, 2023 08:40
@MohamedElmdary MohamedElmdary marked this pull request as ready for review December 31, 2023 10:21
@AhmedHanafy725 AhmedHanafy725 merged commit e4f05ed into development Dec 31, 2023
2 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_enhance_workload_validation branch December 31, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees

@MohamedElmdary MohamedElmdary

Labels
grid_client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohamedElmdary @zaelgohary @AhmedHanafy725