Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable creating 2 farms with same name #2156

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Feb 13, 2024

Description

Create farm in your farms tab is case senestive;
which means the one user can crerate mutltiple farms with the same name !
and when come to search by name (its not case sensitive)

Changes

  • added function returns all farms names', then check the entered name in lower case doesn't exist.

Related Issues

#1790

Screencast.from.02-13-2024.11.28.35.AM.webm

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move this step to be a validation function, we already have the farm names and there is no requests to wait for, also the error is created by our side, I believe it will be great to make it validator role, what do you think ?

@AlaaElattar
Copy link
Contributor Author

I suggest to move this step to be a validation function, we already have the farm names and there is no requests to wait for, also the error is created by our side, I believe it will be great to make it validator role, what do you think ?

should be done

Screenshot from 2024-02-14 12-05-29

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ya Alaa great job!

@AlaaElattar AlaaElattar merged commit c2b7cba into development Feb 14, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_check_farmName branch February 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants