Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin to the footer #2323

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Mar 4, 2024

Description

Add some margin-top to the footer

Changes

image

Related Issues

#2261

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad Mahmoud-Emad self-requested a review March 4, 2024 10:07
@Mahmoud-Emad
Copy link
Contributor

Does this need to be in the center?

  • image

@samaradel
Copy link
Contributor Author

@ehab-hassan can you confirm, please?

@ehab-hassan
Copy link
Contributor

ehab-hassan commented Mar 4, 2024

@ehab-hassan can you confirm, please?

yes, please

@amiraabouhadid amiraabouhadid merged commit 089c3c1 into development_314 Mar 4, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_314_footer branch March 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants