Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated links on the landing page and minting details #2376

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Fix outdated links on the landing page and minting details #2376

merged 2 commits into from
Mar 10, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Mar 7, 2024 •
edited
Loading

Description

Fix outdated links on the landing page and minting details as per discussion with @samtaggart

Changes

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@amiraabouhadid amiraabouhadid self-requested a review March 10, 2024 09:47
maayarosama
maayarosama reviewed Mar 10, 2024
View reviewed changes
Copy link
Contributor

@maayarosama maayarosama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In minting page the following
2024-03-10_11-50_1

navigates to FAQ page
2024-03-10_11-50

@samaradel
Copy link
Contributor Author

@samtaggart the new link does not exist in the manual. can you confirm, please

@samaradel samaradel marked this pull request as draft March 10, 2024 10:20
@samaradel samaradel mentioned this pull request Mar 10, 2024
Closed
@samaradel
Copy link
Contributor Author

@maayarosama good catch, thanks :)

@samaradel samaradel mentioned this pull request Mar 10, 2024
Closed
@samaradel samaradel marked this pull request as ready for review March 10, 2024 13:10
@samaradel samaradel merged commit f5f228c into development Mar 10, 2024
3 checks passed
@samaradel samaradel deleted the development_outdated_links branch March 10, 2024 13:11
@samtaggart
Copy link

Hello am I still needed here? Looks like the PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama left review comments

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samaradel @samtaggart @zaelgohary @amiraabouhadid @maayarosama