Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed deployments warning in k8s #2417

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

zaelgohary
Copy link
Contributor

Description

Fix failed deployments warning in k8s

image

Changes

  • remove unused import
  • remove unused variable
  • apply failed deployments changes in k8s

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
Copy link
Contributor

Please try to use the same component used in virtual-machine or at least style it same as the other one

image

@zaelgohary
Copy link
Contributor Author

Please try to use the same component used in virtual-machine or at least style it same as the other one

image

This goes beyond this PR. This PR is meant to show the failed deployment warning only. If we want to change the style in its details, we can open an issue.

Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Zainab :)

@zaelgohary zaelgohary merged commit 10a21ce into development Mar 13, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_k8s_failed_deployments branch March 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants