Implementing Multiple SSH Keys with Enhanced Management Features #2463

Mahmoud-Emad · 2024-03-18T15:16:44Z

Description

Implemented multiple SSH key feature and SSH key management

Changes

Implemented a helper function to generate a name for the generated key to be saved with the key.
Added activation and deletion logic for SSH keys.
Worked on the feature to delete all selected keys, preparing to delete keys based on types like active or all keys.
Unified UI elements by removing the tonal theme from cards to maintain consistency with the contracts list view.
Enhanced UI by adding another dialog for importing SSH keys and updated the colors of the table.
Calculated SSH key fingerprints, consolidated form dialogs, and introduced a key details dialog while removing redundant dialog.
Refined the copy input wrapper to conditionally display the copy icon based on field data presence and improved the functionality of the generate dialog.
Migrated old SSH keys to the new SSH key type and set them as active keys.
Fixed the issue when saving SSH keys by loading them from the chain instead. Work in progress on updating the chain when pressing on active/inactive or deleting keys.
Enhanced the way of saving/removing the keys and improved the import key form by adding a rule to validate the entered SSH key.
Merged SSH key management functionality into all applications.

Related Issues

Enhancement Request: Implementing Multiple SSH Keys with Enhanced Management Features #1882

Screenshots

Checklist

…ed key to be saved with the key, added some UI enhancements.

…delete the keys based on the types like active or all keys.

…to maintain consistency with the contracts list view. Eliminated the onClickRow method as all necessary data is now displayed directly on the SSH-key table. Updated color schemes for both light and dark themes.

…ssh-key, updated the colors of the table.

…and introduced key details dialog. Removed redundant dialog.

…opy icon based on field data presence, and improved the functionality of the generate dialog.

… active key.

…rom the chain instead, WIP: update the chain when pressing on active/inactive or even on delete .

…the the import key form by added a rule to validate the entred sshkey.

… management prior to deployment in the fullVM module. Work in progress: Standardizing the inclusion of this feature across all deployments.

…n the SSH key selector for improved visual consistency. Resolved an issue with importing the SSH key dialog. Enhanced user experience by implementing clearer messaging.

…ications..

packages/playground/src/components/ssh_keys/ManageSshDeployemnt.vue

…es in the listing table.

Remove key fragments after setting a key with a new value

amiraabouhadid

It says that this sshkey was created today. However, this sshkey was created long before today.

MohamedElmdary · 2024-04-01T12:48:33Z

Deploy button need to be disable if no key is select

How to do that?

basically, use our validator form api but manually
example for such solution can be found here https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/playground/src/components/node_selector/TfSelectionDetails.vue#L144

- style: remove action/inactive btn and turn them into checkbox - style: remove view btn and move action to click:row

…efoldtech/tfgrid-sdk-ts into development_multiple_sshkey

- feat: Add disable/enable (aka. validation) to ssh management component - style: add some whitespaces based on defined btns in all other components

Mahmoud-Emad · 2024-04-02T10:58:11Z

It says that this sshkey was created today. However, this sshkey was created long before today.

I have keys created since 31/3, it's not an issue anyway.

MohamedElmdary

Good job

WIP: Working on designing the multiple ssh-keys feature.

b13afe8

Mahmoud-Emad requested review from AhmedHanafy725, zaelgohary, maayarosama, MohamedElmdary, amiraabouhadid, AlaaElattar, 0oM4R, mohamedamer453 and samaradel as code owners March 18, 2024 15:16

Mahmoud-Emad marked this pull request as draft March 18, 2024 15:16

Mahmoud-Emad added 14 commits March 19, 2024 01:31

WIP: Implemented a helper function to generate a name for the generat…

ba36f4d

…ed key to be saved with the key, added some UI enhancements.

WIP: Added the activation and deletion logic.

e98a0aa

WIP: Worked on deleting all selected keys featrue, now preparing the …

82c8875

…delete the keys based on the types like active or all keys.

Refactor: Unified UI elements by removing the tonal theme from cards …

cbb65bb

…to maintain consistency with the contracts list view. Eliminated the onClickRow method as all necessary data is now displayed directly on the SSH-key table. Updated color schemes for both light and dark themes.

Refactor: Enhanced the UI by adding another dialog for importing the …

b03bed0

…ssh-key, updated the colors of the table.

Refactor: Calculated SSH key fingerprint, consolidated form dialogs, …

52d5365

…and introduced key details dialog. Removed redundant dialog.

Update: Refined the copy input wrapper to conditionally display the c…

074163a

…opy icon based on field data presence, and improved the functionality of the generate dialog.

Update: Migrate the old SSH-Key to the new SSH-Key type and set it as…

24799c2

… active key.

Fix: Fixed the issue when saving the ssh-keys, loading the ssh-keys f…

b37adef

…rom the chain instead, WIP: update the chain when pressing on active/inactive or even on delete .

Enhancements: Enhanced the way of saving/removing the keys, improved …

4b887f4

…the the import key form by added a rule to validate the entred sshkey.

Merge branch 'development' into development_multiple_sshkey

44187e9

Enhancement: Integrated SSH key selection component to facilitate key…

1967d1e

… management prior to deployment in the fullVM module. Work in progress: Standardizing the inclusion of this feature across all deployments.

Enhancement: Substituted the card component with a v-chip component i…

c33683c

…n the SSH key selector for improved visual consistency. Resolved an issue with importing the SSH key dialog. Enhanced user experience by implementing clearer messaging.

Work Completed: Merged SSH key management functionality into all appl…

f09e8df

…ications..

Mahmoud-Emad force-pushed the development_multiple_sshkey branch from cdbea0b to e37df5d Compare March 27, 2024 00:28

Fix: Fix playground build.

664dcc7

Mahmoud-Emad force-pushed the development_multiple_sshkey branch from e37df5d to 664dcc7 Compare March 27, 2024 00:35

Mahmoud-Emad marked this pull request as ready for review March 27, 2024 00:45

MohamedElmdary reviewed Mar 27, 2024

View reviewed changes

packages/playground/src/components/ssh_keys/ManageSshDeployemnt.vue Show resolved Hide resolved

AhmedHanafy725 and others added 8 commits March 27, 2024 13:51

Remove key fragments after setting key with new value

239ab07

Enhancement: Download the private key when generate it, fix some issu…

bb51347

…es in the listing table.

Reuse clean fragments in remove method

46b7b97

Merge pull request #2503 from threefoldtech/development_clean_kvstore

902046d

Remove key fragments after setting a key with a new value

Update: Migrate SSH_Table_View to V3 instead of V3

fe5b211

Update: Migrate SSH components to V3 instead of V3

6657440

Merge branch 'development' into development_multiple_sshkey

996736a

Update: Migrate SSH components to V3 instead of V3

e674520

Mahmoud-Emad force-pushed the development_multiple_sshkey branch from 0ae5cf2 to e674520 Compare March 31, 2024 11:20

Fix: fix playground build.

54cc569

amiraabouhadid reviewed Apr 1, 2024

View reviewed changes

Mahmoud-Emad and others added 5 commits April 2, 2024 11:22

Merge branch 'development' into development_multiple_sshkey

8045139

- fix: checkbox handler wasn't correctly named

4ce8312

- style: remove action/inactive btn and turn them into checkbox - style: remove view btn and move action to click:row

Enhancements: Removed unused btn.

ba6cb05

Merge branch 'development_multiple_sshkey' of https://github.com/thre…

7b9b2c9

…efoldtech/tfgrid-sdk-ts into development_multiple_sshkey

- style: Move alert outside component

35110eb

- feat: Add disable/enable (aka. validation) to ssh management component - style: add some whitespaces based on defined btns in all other components

MohamedElmdary approved these changes Apr 4, 2024

View reviewed changes

amiraabouhadid approved these changes Apr 7, 2024

View reviewed changes

amiraabouhadid merged commit 6e2902d into development Apr 7, 2024
3 checks passed

amiraabouhadid deleted the development_multiple_sshkey branch April 7, 2024 03:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing Multiple SSH Keys with Enhanced Management Features #2463

Implementing Multiple SSH Keys with Enhanced Management Features #2463

Mahmoud-Emad commented Mar 18, 2024 •

edited

Loading

amiraabouhadid left a comment

MohamedElmdary commented Apr 1, 2024

Mahmoud-Emad commented Apr 2, 2024 •

edited

Loading

MohamedElmdary left a comment

Implementing Multiple SSH Keys with Enhanced Management Features #2463

Implementing Multiple SSH Keys with Enhanced Management Features #2463

Conversation

Mahmoud-Emad commented Mar 18, 2024 • edited Loading

Description

Changes

Related Issues

Screenshots

Checklist

amiraabouhadid left a comment

Choose a reason for hiding this comment

MohamedElmdary commented Apr 1, 2024

How to do that?

Mahmoud-Emad commented Apr 2, 2024 • edited Loading

MohamedElmdary left a comment

Choose a reason for hiding this comment

Mahmoud-Emad commented Mar 18, 2024 •

edited

Loading

Mahmoud-Emad commented Apr 2, 2024 •

edited

Loading