Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit 'Delete IP' to 'Delete', Replace unnecessary log, Edit yarn lock #2467

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Edit 'Delete IP' to 'Delete', Replace unnecessary log, Edit yarn lock #2467

merged 1 commit into from
Mar 19, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Mar 18, 2024 •
edited
Loading

Description

  • Edit 'Delete IP' to 'Delete'
  • Replace unnecessary log,
  • Edit yarn lock

image

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary merged commit 9c162e4 into development Mar 19, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_rename_delete_ip_btn branch March 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaelgohary @AhmedHanafy725 @0oM4R