Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stellar address validation #2486

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Stellar address validation #2486

merged 8 commits into from
Mar 26, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Mar 20, 2024

Description

we have two places that we need to validate stellar addresses, Your farms and Withdraw dialog

Changes

  • moved the addressValidation logic to validators
  • Used form validator and Input validator component to use async rules
  • applied the address validation rules on both your farms and withdraw dialogs

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R added 4 commits March 20, 2024 13:59
@0oM4R
Update:
8de7e10 
add stellar address validation rule to validators
@0oM4R
Update:
f48cc9b 
use InputValidator and asyncRules to validate stellar address
@0oM4R
Update:
1c4c78c 
 use isValidStellarAdress in stellar farm
@0oM4R
Fix: disable send btn on invalid amount
588a416 
used form validator and inputValidator component to apply this rules
@0oM4R
apply comments:
fa6717a 
Update: remvoe unused import
Update: remove passing address to funtion as it already take the ref
@0oM4R 0oM4R requested a review from MohamedElmdary March 24, 2024 12:40
@0oM4R 0oM4R marked this pull request as draft March 24, 2024 13:02
@0oM4R 0oM4R requested a review from MohamedElmdary March 24, 2024 13:28
@0oM4R 0oM4R marked this pull request as ready for review March 24, 2024 13:28
zaelgohary
zaelgohary reviewed Mar 24, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Omar. just some small comments.

packages/playground/src/components/withdraw_dialog.vue Outdated Show resolved Hide resolved
packages/playground/src/components/withdraw_dialog.vue Outdated Show resolved Hide resolved
packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved
packages/playground/src/utils/validators.ts Outdated Show resolved Hide resolved
0oM4R and others added 3 commits March 24, 2024 15:47
@0oM4R @zaelgohary
Update packages/playground/src/components/withdraw_dialog.vue
8ba49b6 
Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>
@0oM4R
Fix: make error message starts with upper case
1ca80d9
@0oM4R
Update:
174ec49 
move validation function to valiedators
@0oM4R 0oM4R requested a review from zaelgohary March 24, 2024 15:50
@0oM4R 0oM4R merged commit 6b6b95f into development Mar 26, 2024
3 checks passed
@0oM4R 0oM4R deleted the development_addressValidation branch March 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0oM4R @MohamedElmdary @zaelgohary