Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filters to side instead of top #2516

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

MohamedElmdary
Copy link
Member

Description

Moved filters to side instead of top

Changes

Farms page

image

Nodes Page

image

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@ehab-hassan
Copy link
Contributor

ehab-hassan commented Mar 31, 2024

@MohamedElmdary can u make all filed and labels also buttons font size 0.875rem
Note: if it is affected at all dashboard that is good, because that is supposed to be the default size for theme

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels size look way too big compared to the side menu

image

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filters are not responsive. Maybe we should keep them horizontal in smaller screens?

image

feat: Add onResize for response to resizing window and flipping mobile in App.vue
chore: Add some classes to allow selecting elements globally
style: resize filters container to 300 instead of 320
style: update styles for filter in nodes and farms pages using newly added selectors
feat: make filters collapsible whenever breakpoint is greater than window size
@ehab-hassan
Copy link
Contributor

image
apply button color change at a small size let's keep it a secondary color outlined

@zaelgohary
Copy link
Contributor

@MohamedElmdary Amazing!

@MohamedElmdary MohamedElmdary merged commit ac00f84 into development Apr 3, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_update_filters_ui branch April 3, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants