Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pricing calculator accepting negative values #2518

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix pricing calculator accepting negative values #2518

merged 2 commits into from
Apr 8, 2024

Conversation

MohamedElmdary
Copy link
Member

Description

Fix pricing calculator accepting negative values
image

Changes

  • export 'State' because it show error that's it's used while it's private
  • fix: add conditions to show error if used wrong values
  • export 'PricingInfo' from grid_client package because it show error that it's used while it's private

Related Issues

Documentation PR

For UI changes, Plaese provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary
- export 'PricingInfo' from grid_client package because it show error…
0cf2954 
… that it's used while it's private

- export 'State' because it show error that's it's used while it's private
- fix: add conditions to show error if used wrong values
@MohamedElmdary MohamedElmdary self-assigned this Apr 1, 2024
zaelgohary
zaelgohary reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the error message from the screenshot as it has a typo?

'It should be 'Please provide valid data in order to calculate ...'

image

Also, CPU error message should be the same phrasing as the rest.

@zaelgohary zaelgohary mentioned this pull request Apr 2, 2024
Closed
5 tasks
Mahmoud-Emad
Mahmoud-Emad approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Rabeea

@MohamedElmdary MohamedElmdary merged commit f1720d3 into development Apr 8, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_fix_pricing_calc branch April 8, 2024 10:07
@samaradel samaradel mentioned this pull request Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees

@MohamedElmdary MohamedElmdary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohamedElmdary @zaelgohary @Mahmoud-Emad