Update sshkey page #2554

samaradel · 2024-04-14T14:19:21Z

Description

Remove Active keys table
Add all keys into one table
generate a name for keys that haven't a name
Reduce the size of titles
prevent opening the dialog of ssh key details by clicking on the active checkbox
Generate name when the key is imported without name

Changes

Related Issues

Checklist

- Add all keys in one table - generate name for keys which havnt a name - Reduce size of titles - prevent opening the dialog of sshkey details on click on active checkbox

AlaaElattar

Great Job

Mahmoud-Emad

Good job ya Samar,

as we agreed we have to migrate the old key once the user logs in in the background.

The SSH key can be without a name, so we need to update the validation rule to accept keys with no names.

I deleted the name when importing a new SSH key and it doesn't generate a name for me, it displayed as -, in this case, I think we should generate a name on behalf of the user as we displayed it in the input hint.

Should we enable the loader while activating/deactivating the SSH key?

Screencast.from.04-15-2024.08.52.33.AM.webm

I deleted a key then generated a new one and got the deleted key and the generated key with the same ID

Screencast.from.04-15-2024.08-57-15.AM.mp4

When deleted the SSH key name when generating new one I expect that you'll generate another one for me but got a dash -

- Migrate keys on login/connect

- Fix sshkeyData type

This reverts commit cbd67ef.

This reverts commit 4afe88e.

This reverts commit 3245d9d.

This reverts commit 3c4f6f5.

This reverts commit 5153e27.

- The validation rule was modified to accept keys without names - Take the key name when importing an 'SSH key' if exists or generate a new one - Migrating the old ssh key after activating the 'profile manager' - Created a class named 'SSHKeyData' that holds all 'SSH' functionality, to avoid code duplication since there are some functions that need to be imported into other places - Disable the 'Import', 'Generate', and 'Export' buttons while 'Deleteing', 'Creating', and 'Updating' keys to avoid errors - Wait on the chain to finish the task then update the table of 'ssh keys'

packages/playground/src/utils/validators.ts

0oM4R

great job, we just need to pay attention to error handling.

zaelgohary · 2024-04-18T13:56:32Z

Can we change the info to be "Manage SSH keys easily, switch between them, and activate or deactivate keys as needed for accessing deployed machines. Simplify key distribution and effectively manage access to nodes."

tfgrid-sdk-ts/packages/playground/src/views/sshkey_view.vue

Lines 9 to 12 in 9ce6514

    
           Facilitating access to deployed machines involves the incorporation or adaptation of SSH keys, with the 
        
           flexibility to manage multiple keys seamlessly, allowing users to switch between them. Moreover, users can 
        
           activate individual keys or enable them all, streamlining the process of distributing them to the machines and 
        
           effectively managing accessibility to the deployed nodes.

zaelgohary · 2024-04-18T14:18:59Z

The lower export button doesn't work as expected.

export_ssh.webm

- Rename the tab of 'SSH Key' to 'SSH Keys' to match the new feature - Generate a unique name/key and check if any of them exists on the profile keys - Check the user balance if enough or not before updating the chain and notify the user - Rename the text area and input fields - Migrate and take the old key in deployment if the balance isn't enough to avoid errors

…ted keys then pass them.

@click

- Removed the hard-coded cost balance and make it variable instead - Updated the @click:row event - Removed unneeded alert message

zaelgohary

Good job, Emad!

0oM4R

I still have an unhanded errors on low balance account

0oM4R

On low balance, an error is handled, but the status has changed!
After reloading the page, the status went back to active.
also i think the toast should have more friendly message
Screencast from 21 أبر, 2024 EET 11:21:09 ص.webm

packages/playground/src/utils/ssh.ts

packages/playground/src/views/sshkey_view.vue

0oM4R

Thanks ya Omda great job

- Remove Active keys table

0c8d798

- Add all keys in one table - generate name for keys which havnt a name - Reduce size of titles - prevent opening the dialog of sshkey details on click on active checkbox

samaradel requested review from AhmedHanafy725, zaelgohary, maayarosama, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar, 0oM4R and mohamedamer453 as code owners April 14, 2024 14:19

MohamedElmdary approved these changes Apr 14, 2024

View reviewed changes

AlaaElattar approved these changes Apr 14, 2024

View reviewed changes

Mahmoud-Emad requested changes Apr 15, 2024

View reviewed changes

samaradel marked this pull request as draft April 15, 2024 07:17

samaradel and others added 13 commits April 16, 2024 11:59

- Collect SSH key functions in one file

5153e27

- Migrate keys on login/connect

remove type keyword

3c4f6f5

- Update functions with grid

3245d9d

- Fix sshkeyData type

Remove sshkey name from validator regex

4afe88e

Add migrateSshKeys function in activate function

cbd67ef

Revert "Add migrateSshKeys function in activate function"

fbdba43

This reverts commit cbd67ef.

Revert "Remove sshkey name from validator regex"

4b56259

This reverts commit 4afe88e.

Revert "- Update functions with grid"

f1963fa

This reverts commit 3245d9d.

Revert "remove type keyword"

a366dc9

This reverts commit 3c4f6f5.

Revert "- Collect SSH key functions in one file"

382f06a

This reverts commit 5153e27.

Fix listing imported keys when its imported without name

14d3005

Apply loading while activating or deactivating ssh keys

8957552

Mahmoud-Emad force-pushed the development_sshkeys branch from 718a23e to 9ce6514 Compare April 18, 2024 07:44

Mahmoud-Emad marked this pull request as ready for review April 18, 2024 07:47

Mahmoud-Emad requested a review from MohamedElmdary April 18, 2024 07:56

0oM4R reviewed Apr 18, 2024

View reviewed changes

packages/playground/src/utils/validators.ts Show resolved Hide resolved

0oM4R requested changes Apr 18, 2024

View reviewed changes

Mahmoud-Emad marked this pull request as draft April 18, 2024 14:08

Mahmoud-Emad added 4 commits April 18, 2024 19:51

Removed unused loggers.

33eb81e

Update the header font size.

c5fd3b5

Fix: Fixed the issue of exporting some keys by looping over the selec…

709a1a8

…ted keys then pass them.

Mahmoud-Emad marked this pull request as ready for review April 18, 2024 18:01

Mahmoud-Emad requested review from Mahmoud-Emad, 0oM4R, zaelgohary and MohamedElmdary April 18, 2024 18:01

Enhancements:

e3359fd

- Removed the hard-coded cost balance and make it variable instead - Updated the @click:row event - Removed unneeded alert message

Mahmoud-Emad force-pushed the development_sshkeys branch from 7d37d55 to e3359fd Compare April 21, 2024 07:34

zaelgohary approved these changes Apr 21, 2024

View reviewed changes

0oM4R requested changes Apr 21, 2024

View reviewed changes

Fix: Handled Insufficient Balance Error

b2acbb5

0oM4R requested changes Apr 21, 2024

View reviewed changes

packages/playground/src/utils/ssh.ts Outdated Show resolved Hide resolved

Update: Update the status of the key if the balance is enough

bd73ce3

0oM4R reviewed Apr 21, 2024

View reviewed changes

packages/playground/src/utils/ssh.ts Outdated Show resolved Hide resolved

0oM4R reviewed Apr 21, 2024

View reviewed changes

packages/playground/src/views/sshkey_view.vue Show resolved Hide resolved

0oM4R approved these changes Apr 21, 2024

View reviewed changes

Update: Handle error message, handle error blocks.

d097eea

Mahmoud-Emad requested a review from 0oM4R April 21, 2024 12:28

0oM4R approved these changes Apr 21, 2024

View reviewed changes

Mahmoud-Emad approved these changes Apr 21, 2024

View reviewed changes

samaradel merged commit 2c8c89b into development Apr 21, 2024
3 checks passed

samaradel deleted the development_sshkeys branch April 21, 2024 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sshkey page #2554

Update sshkey page #2554

samaradel commented Apr 14, 2024 •

edited by Mahmoud-Emad

Loading

AlaaElattar left a comment

Mahmoud-Emad left a comment •

edited

Loading

0oM4R left a comment

zaelgohary commented Apr 18, 2024

zaelgohary commented Apr 18, 2024

zaelgohary left a comment

0oM4R left a comment

0oM4R left a comment

0oM4R left a comment

Update sshkey page #2554

Update sshkey page #2554

Conversation

samaradel commented Apr 14, 2024 • edited by Mahmoud-Emad Loading

Description

Changes

Related Issues

Checklist

AlaaElattar left a comment

Choose a reason for hiding this comment

Mahmoud-Emad left a comment • edited Loading

Choose a reason for hiding this comment

0oM4R left a comment

Choose a reason for hiding this comment

zaelgohary commented Apr 18, 2024

zaelgohary commented Apr 18, 2024

zaelgohary left a comment

Choose a reason for hiding this comment

0oM4R left a comment

Choose a reason for hiding this comment

0oM4R left a comment

Choose a reason for hiding this comment

0oM4R left a comment

Choose a reason for hiding this comment

samaradel commented Apr 14, 2024 •

edited by Mahmoud-Emad

Loading

Mahmoud-Emad left a comment •

edited

Loading