Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to vuetify v3.5.x #2644

Merged
merged 22 commits into from
May 13, 2024
Merged

Upgrade to vuetify v3.5.x #2644

merged 22 commits into from
May 13, 2024

Conversation

MohamedElmdary
Copy link
Member

Description

Upgrade to vuetify v3.5.x

Changes

  • chore: upgrade vuetify package from 3.1.x to 3.4.x
  • fix: Remove files from labs as it's now stable in components
  • fix: Loading spinner inside button component
  • fix: Breadcrumb navigator
  • fix: deployments table data
  • fix: manage gateway table
  • fix: k8s deployment table
  • fix: contracts list table
  • fix: caprover manage worker dialog table
  • fix: public ips table
  • fix: user farms table
  • fix: user nodes table
  • fix: farm finder dialog table
  • fix: turn into
    to solve unexpected bug
  • fix: selection in table
  • feat: Add update method as prop in -actions slots
  • fix: use update method to update caprover worker after deploy/delete

    • Related Issues

    Documentation PR

    For UI changes, Please provide the Documetation PR on info_grid

    Checklist

    • Tests included
    • Build pass
    • Documentation
    • Code format and docstrings
    • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary
chore: upgrade vuetify package from 3.1.x to 3.4.x
9928e58
@MohamedElmdary
fix: Remove files from labs as it's now stable in components
3b09163
@MohamedElmdary
fix: Loading spinner inside button component
e9caab7
@MohamedElmdary
fix: Breadcrumb navigator
eedb6d4
@MohamedElmdary
fix: deployments table data
34b75a6
@MohamedElmdary
fix: manage gateway table
ac47165
@MohamedElmdary
fix: k8s deployment table
5445a7b
@MohamedElmdary
fix: contracts list table
0444e5b
@MohamedElmdary
fix: caprover manage worker dialog table
8b107a8
@MohamedElmdary
fix: public ips table
e0921be 
fix: user farms table
fix: user nodes table
@MohamedElmdary
fix: farm finder dialog table
51044ed
@MohamedElmdary
fix: turn <template v-if> into <div v-show> to solve unexpected bug
06f3ce6
@MohamedElmdary
Merge branch 'development_2.5' into development_2.5_upgrade_vuetify
24aff70
@MohamedElmdary
fix: selection in table
bfc8cbf 
feat: Add update method as prop in -actions slots
fix: use update method to update caprover worker after deploy/delete
@MohamedElmdary MohamedElmdary self-assigned this May 2, 2024
@MohamedElmdary MohamedElmdary marked this pull request as draft May 2, 2024 11:14
@MohamedElmdary MohamedElmdary marked this pull request as ready for review May 2, 2024 11:15
Mahmoud-Emad
Mahmoud-Emad approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Mahmoud-Emad Mahmoud-Emad self-requested a review May 2, 2024 11:54
@Mahmoud-Emad
Copy link
Contributor

Mahmoud-Emad commented May 2, 2024 •
edited
Loading

Check the node finder page, please

Base automatically changed from development_2.5 to development May 7, 2024 12:16
An error occurred while trying to automatically change base from development_2.5 to development May 7, 2024 12:16
0oM4R
0oM4R reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we change the style of toggles ?
the current one
image

the new one :
image

0oM4R
0oM4R previously requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data in backend column should'n be like this
image
this may not related to your changes, but the case in 2.4.0 is :
image

so please merge latest branch to this one

@MohamedElmdary
Copy link
Member Author

do we change the style of toggles ? the current one image

the new one : image

I think we should stick with ui changes as it doesn't affect ux

@zaelgohary
Copy link
Contributor

Playground build is failing.

@MohamedElmdary
Copy link
Member Author

Playground build is failing.

yes after merging from development it appears that there is files still using old vuetify api so I did some updates to fix it

@amiraabouhadid amiraabouhadid requested a review from 0oM4R May 9, 2024 11:35
amiraabouhadid
amiraabouhadid previously approved these changes May 9, 2024
View reviewed changes
@amiraabouhadid amiraabouhadid dismissed their stale review May 9, 2024 11:55

found issue in btn spinner

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented May 9, 2024 •
edited
Loading

spinners are larger than button
image

image

image

amiraabouhadid
amiraabouhadid reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinner size fixed
image

zaelgohary
zaelgohary reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tables are not shown.

image

Deployment table is missing. I think this goes for all solutions

image

image

Node finder table size is not right.

image

Link color is not added

image

Staging:
image

Get TFT fails although it's working on staging.
image

@zaelgohary
Copy link
Contributor

zaelgohary commented May 9, 2024 •
edited
Loading

All issues were fixed by building the project except for the Get TFT button.

@MohamedElmdary
Copy link
Member Author

All issues were fixed by building the project except for the Get TFT button.

@zaelgohary
After investing in get tft button I found that issue related to this PR https://github.com/threefoldtech/tfgrid-sdk-ts/pull/2563/files#diff-fce083955bd2accb8ca8a9c35f2f4c1915853c058393a1b14e1ae26dad9aa2c0R43-R45

@zaelgohary
Copy link
Contributor

zaelgohary commented May 12, 2024 •
edited
Loading

@zaelgohary After investing in get tft button I found that issue related to this PR https://github.com/threefoldtech/tfgrid-sdk-ts/pull/2563/files#diff-fce083955bd2accb8ca8a9c35f2f4c1915853c058393a1b14e1ae26dad9aa2c0R43-R45

You may open an issue for it so it won't be discarded.

zaelgohary
zaelgohary approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue for the get TFT button. Good job, Rabei!

@0oM4R 0oM4R dismissed their stale review May 13, 2024 07:15

resolved

@amiraabouhadid amiraabouhadid merged commit a11a892 into development May 13, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_2.5_upgrade_vuetify branch May 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid left review comments

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees

@MohamedElmdary MohamedElmdary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MohamedElmdary @Mahmoud-Emad @zaelgohary @amiraabouhadid @0oM4R