Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 0% staking discount while having enough tokens to unlock the gold discount #2649

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix: 0% staking discount while having enough tokens to unlock the gold discount #2649

merged 2 commits into from
May 7, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented May 7, 2024 •
edited
Loading

Description

Fixed the 0% staking discount while having enough tokens to unlock the gold discount

Changes

  • Added a loader when loading the value of the discount
  • Added a watcher that watches on the profile when connecting the wallet
  • Updated the discount when connected to the wallet
  • Highlighted the balance value by wrapping it with a 'strong' tag

Related Issues

Screenshots/Video

  • image

  • Screencast.from.05-07-2024.11.51.07.AM.webm

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
Fix: 0% staking discount while having enough tokens to unlock the gol…
d975118 
…d discount

- Added a loader when loading the value of the discount
- Added a watcher that watch on the profile when connecting the wallet
- Updated the discount when connect to the wallet
- Highlighted the balance value by wrapping it with a 'strong' tag
@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft May 7, 2024 09:18
@Mahmoud-Emad
Copy link
Contributor Author

Converted to draft until we merge the development2.5

@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review May 7, 2024 12:17
zaelgohary
zaelgohary approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amiraabouhadid
amiraabouhadid requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am logged out but I still get 50% discount
image

@Mahmoud-Emad
Copy link
Contributor Author

I am logged out but I still get 50% discount image

It's 0 not 50, check the staking discount please :)

@amiraabouhadid amiraabouhadid merged commit 92190fc into development May 7, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_staking_discount branch May 7, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mahmoud-Emad @zaelgohary @amiraabouhadid