Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance inputs in light theme #2739

Merged
merged 6 commits into from
May 23, 2024
Merged

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented May 20, 2024

Description

Enhance UI components in light theme

Changes

image
image
image
image
image
image
image
image
image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
Copy link
Contributor

i don't know if it feasible or not but when hover on a country in the statistic page I see the tooltip dark in light theme

image

@Mahmoud-Emad
Copy link
Contributor

most of the inputs are still not dealing with the light theme, look at the simulator page, Do you think it needs to be outlined in the light mode?

image

@Mahmoud-Emad
Copy link
Contributor

The colors here also are not clear at all

image

@maayarosama
Copy link
Contributor

  • In the home page:
  1. Map doesn't look clear at all
  2. I can't really see the learn about the grid button, so I suggest changing its color to mint green like the get tft button
  3. The icon below the map aren't clear, can we make the color more intense so they became clearer?

Screenshot from 2024-05-21 11-13-49

  • In pricing calculator page:
  1. The gradient gold package doesn't look good against the bright white background, I suggest removing the bright intense white background across the dashboard and making it less intense white color or a light gray

Screenshot from 2024-05-21 11-13-49

  • In node finder page:
  1. the progress bar, The unfilled part is not really clear against the white background, I suggest increasing the opacity a little bit

2024-05-21_11-34

  • In the applications page:
  1. the static website's icon has a black background

Screenshot from 2024-05-21 11-38-24

  • In simulator page:
  1. Values in disabled field aren't clear
    Screenshot from 2024-05-21 11-46-55

@samaradel samaradel marked this pull request as draft May 21, 2024 09:34
@samaradel samaradel marked this pull request as ready for review May 21, 2024 14:18
@ehab-hassan
Copy link
Contributor

i don't know if it feasible or not but when hover on a country in the statistic page I see the tooltip dark in light theme

image

I tried to enhance the UI before but when I checked with @MohamedElmdary it was hard to adjust here, also I think we'll use a new map soon so let's leave it as is for now.

@ehab-hassan
Copy link
Contributor

@maayarosama For the gradient gold package if we change the white BG for the dashboard will not be consistent with other pages but we can add a border that'll make it clearer, what do you think?
image

@maayarosama
Copy link
Contributor

@maayarosama For the gradient gold package if we change the white BG for the dashboard will not be consistent with other pages but we can add a border that'll make it clearer, what do you think? image

I suggest changing the white background across all the dashboard, As the white is too bright and it's harsh on the eyes, what do you think @ehab-hassan ?

@samaradel samaradel marked this pull request as draft May 22, 2024 11:47
@ehab-hassan
Copy link
Contributor

@maayarosama I think if we did that would affect all like fields and disabled objects, and borders will not be clear also I think you used to work in the dark mode so white is too bright for you :) ,we used the same color for GitHub in light mode.

@samaradel samaradel marked this pull request as ready for review May 22, 2024 12:56
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ya Samar, Go ahead

@samaradel samaradel merged commit 3ead850 into development May 23, 2024
3 checks passed
@samaradel samaradel deleted the development_UI_light_theme branch May 23, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants