Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling error in solution without tabs #2782

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented May 27, 2024

Description

Fix handling error in solution without tabs

Changes

  • fix: add d-tabs(config) to solution without tabs
  • fix: some input.$el were refs (unwrapped it)
  • fix: some input.status were refs (unwrapped it)

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

- fix: add d-tabs(config) to tf_casperlabs solution
- fix: add d-tabs(config) to tf_funkwhale solution
- fix: add d-tabs(config) to tf_nextcloud solution
- fix: add d-tabs(config) to tf_node_pilot solution
- fix: add d-tabs(config) to tf_peertube solution
- fix: add d-tabs(config) to tf_staticwebsite solution
- fix: add d-tabs(config) to tf_subsquid solution
- fix: add d-tabs(config) to tf_umbrel solution
- fix: add d-tabs(config) to tf_wordpress solution
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<d-tabs> Should be added to Freeflow.

@MohamedElmdary
Copy link
Member Author

<d-tabs> Should be added to Freeflow.

didn't notice it as it's not listed in solutions. Updated

@Mahmoud-Emad Mahmoud-Emad self-requested a review May 28, 2024 11:57
@0oM4R 0oM4R requested a review from zaelgohary June 4, 2024 09:30
@MohamedElmdary MohamedElmdary merged commit d806ab4 into development Jun 4, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_fix_handle_error_deployers branch June 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants