Enhance the contracts list by removing the duplicate requests, and reduce the time limit when loading the contracts by removing the onMounted lifecycle
#2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the 'onMount' from the 'onMounted' life cycle since it not needed because we call the 'loadContracts' function on each change happens on the table. - Fix the contracts table takes too much time to load.
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
There was a problem hiding this comment.
Good job, would be nice though if we can make only one request for the same node used by multiple contracts instead of for example requesting node 11 here twice
What do you think @AhmedHanafy725 ?
…ntracts_list_page
zaelgohary
approved these changes
Jun 5, 2024
maayarosama
approved these changes
Jun 5, 2024
|
changing table options still takes so much time to load, is there anyway to enhance it ? like client side pagination, for example ? |
- Replaced the static values with 'ref' concept to change the value when needed. - Cached the nodes to use it when re-request to avoid the duplicated requests. - Enhanced the list time by using the ''Promise.all and display what gets finished. - Introduced a new hint alert to inform the user that the table will be reloaded in a bit. - Replaced the 'update-options' event with the 'update-page' and 'update-size' events to avoid requesting on each change happens on the table and only request when changing the page/size. - Created only one function to request to list the contracts based on it's type. - Returned back the 'onMounted' life cycle and called the 'loadContracts' inside it. - Remove the duplicate requests. - Updated the 'getNodeInfo' function to request only the nodes that are not cached.
Mahmoud-Emad
requested review from
MohamedElmdary,
amiraabouhadid,
zaelgohary and
maayarosama
MohamedElmdary
approved these changes
Jun 6, 2024
|
Good job |
maayarosama
approved these changes
Jun 6, 2024
Mahmoud-Emad
deleted the
development_fix_double_requests_in_contracts_list_page
branch
1 task
0oM4R
added a commit
that referenced
this pull request
Jun 13, 2024
…tracts` this is necessary now after changes in #2872
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance the contracts list by removing the duplicate requests, and reduce the time limit when loading the contracts by removing the
onMountedlifecycleChanges
Related Issues
Screenshots/Video
Screencast.from.06-04-2024.06.46.01.PM.webm
Checklist