Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpu input service (aka. fakeService) #2919

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Fix gpu input service (aka. fakeService) #2919

merged 1 commit into from
Jun 9, 2024

Conversation

MohamedElmdary
Copy link
Member

Description

Fix gpu input service (aka. fakeService)

Changes

  • fix: Move watcher down after initialize gpu'fakeService'

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary MohamedElmdary self-assigned this Jun 9, 2024
amiraabouhadid
amiraabouhadid reviewed Jun 9, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console. err is gone when gpu is toggled
image

@MohamedElmdary MohamedElmdary merged commit 0139c63 into development Jun 9, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_fix_gpu_input_service branch June 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees

@MohamedElmdary MohamedElmdary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohamedElmdary @amiraabouhadid @Mahmoud-Emad