Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grid_client dependencies and update release process #3062

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Jul 1, 2024

Description

lerna version command add caret ^ before all upgraded dependencies, this may lead to unwanted version conflicts
the solution is: add exact flag to lerna version command check exact

Changes

  • update grid_client/package.json with gridproxy_client as dependency
  • update release process docs with exact flag

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@@ -16,6 +16,7 @@
"@noble/secp256k1": "^1.7.1",
"@threefold/rmb_direct_client": "^2.5.0-rc3",
"@threefold/tfchain_client": "^2.5.0-rc3",
"@threefold/gridproxy_client": "^2.5.0-rc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to remove ^ from the dependencies?

@0oM4R
Copy link
Contributor Author

0oM4R commented Jul 1, 2024

--exact flag should ignore it and replace it with the exact new version

@0oM4R 0oM4R merged commit dead00a into development Jul 1, 2024
2 checks passed
@0oM4R 0oM4R deleted the development_fix_versions branch July 1, 2024 11:26
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants