Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update error message shown when add domain fails #3616

Merged
merged 1 commit into from
Nov 11, 2024
Merged

update error message shown when add domain fails #3616

merged 1 commit into from
Nov 11, 2024

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Nov 11, 2024 •
edited
Loading

Changes

  • added an error message in case deploy domain fails

Related Issues

#3389

Tested Scenarios

  • add domain, go offline, go back online observe error below
  • press back, view domains list with no error

Checklist

  • Tests included
  • Screenshots/Video attached (needed for UI changes)
    Screenshot from 2024-11-11 11-13-10
    image

@amiraabouhadid amiraabouhadid marked this pull request as ready for review November 11, 2024 09:17
@xmonader xmonader requested a review from ramezsaeed November 11, 2024 09:42
@amiraabouhadid amiraabouhadid merged commit 1ea3613 into development Nov 11, 2024
10 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_add_create_domain_err_msg branch November 11, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramezsaeed ramezsaeed ramezsaeed approved these changes

@samaradel samaradel samaradel approved these changes

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amiraabouhadid @xmonader @samaradel @ramezsaeed