Display tvl w/o connected wallet #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a default `JsonRpcProvider` with our url to the Ethereum node if user is not connected to the any wallet yet to fetch data that does not require a wallet connection- eg. total value locked.
This is a workaround because if we provide wrong param to the contrct's function eg. `undefined` the `_.contract?.interface.encodeFunctionData(_.method, _.args),` will fail. We want to fetch token balances only if a user is connected to a wallet- to avoid passing the `undefined` if a user is not connected yet we pass the `AddressZero` to the `useTokensBalanceCall` hook which uses the `useMulticall` hook.
We should take into account the KEEP tokens staked in `KeepTokenStaking` and T tokens `staked` in `TStakingContract`.
Subscribe to event only if user is connected to a wallet.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/tvl/index.html. |
Update a `useSubscribeToContractEvent` test and add a new test case- test the hook when a user is not connected to a wallet.
In `eceb3d4` we added support for creating a contract instance with a default provider w/o connected wallet and this commit adjusts test cases for this feature.
In `1f4a1dc` we unnecessary updated the `useTokenBalance` hook because we thought this hook was causing the balance update problem after catching the `Transfer` event. There was actually a bug in `useSubscribeToContractEvent` hook which was fixed in `ad0bccd`.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/tvl/index.html. |
There is no need to use `*.tsx` extension. This commit changes extension for this file to `*.ts`.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/tvl/index.html. |
Open
| library, | ||
| active | ||
| ? library | ||
| : new JsonRpcProvider(getEnvVariable(EnvVariable.ETH_HOSTNAME_HTTP)), |
There was a problem hiding this comment.
amazing. this is what we've been missing for a ton of unconnected queries in the app
georgeweiler
approved these changes
Feb 15, 2022
georgeweiler
added a commit
that referenced
this pull request
Sep 8, 2022
Display tvl w/o connected wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #87
This PR adds support for fetching and displaying the tvl w/o connected wallet. It also updates tvl calculations- adds a value of
KEEPtokens staked inKeepTokenStakingcontract andTtokens staked inTTokenStakingcontract.