Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeSpan deserialization wrapper #121

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Add TimeSpan deserialization wrapper #121

merged 1 commit into from
Nov 9, 2020

Conversation

wcoder
Copy link
Contributor

@wcoder wcoder commented Nov 9, 2020

What does this PR do?

Fixes #117

Why are we doing this? Any context or related work?
  • Additional backward compatibility with TimeSpan

@wcoder wcoder mentioned this pull request Nov 9, 2020
Closed
thudugala
thudugala requested changes Nov 9, 2020
View reviewed changes
Copy link
Owner

@thudugala thudugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As NotifyRepeatInterval can be null. Can we please check is it null before getting the value.

@thudugala thudugala self-assigned this Nov 9, 2020
@thudugala
Copy link
Owner

Thank you very much for the pull request

@wcoder
Copy link
Contributor Author

wcoder commented Nov 9, 2020

@thudugala as I can see, everywhere checks are already added

@wcoder wcoder requested a review from thudugala November 9, 2020 21:37
@thudugala thudugala merged commit fe80fd8 into thudugala:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thudugala thudugala thudugala approved these changes

Assignees

@thudugala thudugala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop in ScheduledNotificationWorker
2 participants
@wcoder @thudugala