Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert shortcode #46

Closed
wants to merge 2 commits into from
Closed

Add alert shortcode #46

wants to merge 2 commits into from

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Aug 12, 2023

Summary

Inspired by https://github.com/h-enk/doks/blob/master/layouts/shortcodes/alert.html, but simpler. Content is properly centered vertically.

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

@h-enk
Copy link
Member

h-enk commented Oct 9, 2023 •
edited
Loading

Doks 1.0 introduced Callouts — to replace Alerts. So, I don't think we need this

@salim-b
Copy link
Contributor Author

salim-b commented Oct 26, 2023

Thanks @h-enk, callouts are great!

I've overhauled the underlying code in #72 🙂

@salim-b salim-b closed this Oct 26, 2023
@salim-b salim-b deleted the alert branch October 26, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salim-b @h-enk