Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layouts: properly deprecate .Site.Social usage #20

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

l-zeuch
Copy link
Contributor

@l-zeuch l-zeuch commented Oct 22, 2024

Summary

Hugo recently started throwing an error when accessing .Site.Social.
This has been deprecated since 0.124 and will be removed in 0.137.

Motivation

This package's usage to throw its own deprecation warning makes builds
with a recent hugo version fail (so pretty much everyone's)---remove it.

Signed-off-by: Luca Zeuch l-zeuch@email.de

Checks

  • Read Creating a pull request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test (if relevant) (no such script, but npm run format passes.)

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 2071a89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thulite/seo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@l-zeuch l-zeuch force-pushed the deprecate-site-social branch from 1865268 to 4d82b31 Compare October 22, 2024 10:16
Hugo recently started throwing an error when accessing .Site.Social.
This has been deprecated since 0.124 and will be removed in 0.137.

This package's usage to throw its own deprecation warning makes builds
with a recent hugo version fail (so pretty much everyone's)---remove it.

Signed-off-by: Luca Zeuch <l-zeuch@email.de>
@l-zeuch l-zeuch force-pushed the deprecate-site-social branch from 4d82b31 to 2071a89 Compare October 22, 2024 10:21
Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-enk h-enk merged commit bef5cf9 into thuliteio:main Oct 24, 2024
@l-zeuch l-zeuch deleted the deprecate-site-social branch October 24, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants