Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thunder being locked to 60Hz on 120Hz displays #1010

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

mufeedali
Copy link
Contributor

@mufeedali mufeedali commented Jan 1, 2024

Pull Request Description

Set Thunder to use the highest available display refresh rate.

Issue Being Fixed

On several devices with high refresh rate displays, like my Nothing Phone 1, Flutter apps get locked to 60 FPS even though my display mode is still supposed to be 120 Hz. This should fix it by using the flutter_displaymode plugin to set the highest available refresh rate.

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Everything looks good to me - I made a small adjustment to the changelog so that it's under the correct version (this fix will be slated for 0.2.8)

@hjiangsu hjiangsu merged commit 4278faf into thunder-app:develop Jan 4, 2024
1 check passed
@mufeedali mufeedali deleted the refresh-rate branch January 4, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants