Hotfix to fix issue with wrong default locale causing Thunder to display in RTL #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a hotfix PR which addresses the issue where the "Arabic" language is set by default. This causes Thunder to be RTL when it is not intended. This hotfix targets the main branch so that I can push out this fix for Google Play/App Store
Unfortunately, I'm unable to test this myself as I cannot reproduce the issue on my end. However, it should be a relatively safe change as it just applies the default
enlocale when none is present.Issue Being Fixed
Issue Number: #1024, #929
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?