Fix comment indentation #1430
Merged
Fix comment indentation #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, now it looks like the indicator bar is directly against the side. I think there should be at least one bar's width of space. If you look at the screenshot from the issue, the deferred comment indentation looks right (second arrow), but the actual comment indentation looks like it's twice as much (first arrow).
Does that make any sense? 😆 |
|
Oops, I think the recording cropped out a bit of the side which is why it looks like that. Here's another recording which shows the padding amount! Feel free to run it yourself to see if the padding seems to be okay! Screen.Recording.2024-06-05.at.9.37.44.AM.mov |
|
Oh yeah, much better 😆 Sorry about that! |
micahmo
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes the comment indentation issue mentioned in #1413. I double checked this behaviour with thin/thick comment indicator styles, and colourful/monochrome colours.
Issue Being Fixed
Issue Number: #1413
Screenshots / Recordings
Screen.Recording.2024-06-05.at.8.15.36.AM.mov
Checklist
semanticLabels where applicable for accessibility?