Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image proxy thumbnails not retrieving image dimensions properly #1522

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes an issue where instances using image proxying would fail to retrieve the image dimensions (e.g., lemm.ee).

Issue Being Fixed

Issue Number: #1448

Screenshots / Recordings

Before After
simulator_screenshot_707AEB92-C407-4764-BDBB-2BA211EC9F5C simulator_screenshot_B241B5A1-0FDD-44F6-B414-682A3DCEBC2A

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!!

@hjiangsu hjiangsu merged commit ea5908f into develop Aug 12, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/image-proxy-thumbnails branch August 12, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants