Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Player preferences playing mode (InApp, InAppBrowser,External) #1563

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ggichure
Copy link
Collaborator

Pull Request Description

Video Player preferences playing mode (InApp, InAppBrowser,External).
This applies to both players.

Issue Being Fixed

Issue Number: #1517

Screenshots / Recordings

Screenshot_20240917-143921_Thunder

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu force-pushed the enhancement/video_player_mode branch from cc717dc to 5bdbdec Compare November 27, 2024 16:58
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just made a couple of slight adjustments to the implementation:

  • Rebased branch to sync up with the latest develop changes
  • Simplified the logic for handling external app/custom tabs to make it more readable
  • Minor linting

@hjiangsu hjiangsu merged commit c5a4c6b into thunder-app:develop Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants