Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting and deprecation warnings #1588

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR cleans up some additional linting errors and deprecation notices on the project. As a summary:

  • I've decided to ignore use_build_context_synchronously messages in analysis_options. I haven't noticed any issues with using context within async functions, and the linting messages end up flooding the rest of the more important infos/warnings. If you feel strongly against this move, let me know and I can bring it back!
  • Fixed deprecations with regards to colours (background, onBackground, etc.)
  • Removed unused imports, and unused variables

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should any of the color changes fix any issues, or are they only to address deprecations?

I've decided to ignore use_build_context_synchronously messages in analysis_options. I haven't noticed any issues with using context within async functions, and the linting messages end up flooding the rest of the more important infos/warnings. If you feel strongly against this move, let me know and I can bring it back!

I am totally good with this! The if (context.mounted) thing has always felt like more of a chore with not much benefit. If the context really isn't mounted in some rare cases, then it'll just silently fail.

@hjiangsu
Copy link
Member Author

hjiangsu commented Nov 1, 2024

Should any of the color changes fix any issues, or are they only to address deprecations?

They should only affect deprecations as far as I'm aware. The issues that you mentioned are still present (some of them will be addressed in a different PR, and others will hopefully be fixed when the package transitions out of a dev build)

@hjiangsu hjiangsu merged commit 03a7c2f into develop Nov 1, 2024
1 check passed
@hjiangsu hjiangsu deleted the chore/fix-linting-deprecations branch November 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants