Ability to select app language #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 32.0% (85 of 265 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/uk/
Currently translated at 100.0% (269 of 269 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/
Currently translated at 100.0% (272 of 272 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/
Currently translated at 23.2% (64 of 275 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/sv/
Currently translated at 100.0% (280 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/
Currently translated at 50.0% (140 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/sv/
Currently translated at 50.0% (140 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/sv/
Currently translated at 100.0% (280 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/eo/
Currently translated at 77.5% (217 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/pl/
Currently translated at 30.7% (86 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/uk/
Currently translated at 46.4% (130 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/fi/
Currently translated at 15.0% (42 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/it/
Currently translated at 38.2% (107 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/it/
Currently translated at 55.7% (156 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/it/
Currently translated at 68.5% (192 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/it/
Currently translated at 100.0% (280 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/
Currently translated at 100.0% (280 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/eo/
Currently translated at 90.7% (254 of 280 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/it/
Currently translated at 100.0% (282 of 282 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/es/
Currently translated at 90.7% (256 of 282 strings) Translation: Thunder/Thunder Translate-URL: https://hosted.weblate.org/projects/thunder/thunder/it/
…ature/app-language-selection
hjiangsu
force-pushed
the
feature/app-language-selection
branch
from
1a43d5c to
834af59
Compare
|
@micahmo This is ready for review if you'd like to do a quick test on it! |
micahmo
approved these changes
Nov 24, 2023
Good catch, let me double check that! |
|
Should be good now! I double all the files with https://github.com/thunder-app/thunder/tree/translations/lib/l10n to just make sure we have all the translations in place. |
micahmo
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a PR which introduces the ability to select Thunder's localization language from the Settings page.
This PR changes/introduces a couple new things:
.arbfiles to be alphabetical in order. When adding new translation strings, attempts should be made to ensure it stays in alphabetical order. I have locked Weblate translations temporarily until this is merged in and Weblate is synced up with the .arb changes.LanguageLocalclass was added in to help translate language codes to the respective namesl10n_esperantoto help with the Esperanto localization. Android does not natively support this, so this localization is not part of the default flutter localization packages.Issue Being Fixed
Issue Number: #899
Screenshots / Recordings
translation_setting.mp4
Checklist
semanticLabels where applicable for accessibility?