Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor link long press handling for use with link previews #909

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Nov 22, 2023

Pull Request Description

This PR refactors the link long-press handling so that it can be used elsewhere. Specifically, it is now usable from link previews within posts.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_ZjRk3T1p4L.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit cbcdaf7 into thunder-app:develop Nov 24, 2023
1 check passed
@micahmo micahmo deleted the feature/refactor-link-long-press branch November 24, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants