Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comment/post actions #958

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 5, 2023

Pull Request Description

This PR updates the Post and Comment actions to bring them more in parity with other functionality in the app and with each other.

Review without whitspace.

Post - Added

  • Block User

Comment - Changed

  • Moved Share to top row (like Posts) to make room for more options

Comment - Added

  • Visit User Profile
  • Block User
  • Visit Instance
  • Block Instance (when supported)

I also added a Block/Unblock Instance to the Visit Instance page (when supported).

P.S. In a future update, I would like to replace "user"/"community", etc. with the actual names.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_3pRUbTl3oC.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@machinaeZER0
Copy link
Collaborator

This is nice! I will say, as the list of things we can do on long press grows, it might make sense to start consolidating similar actions? Boost has a setup like this that i like quite a bit, though for some reason it's not accessed through a long press. Screenshots below:

Screenshot_20231205-230203
and on pressing one of the option groups:
Screenshot_20231205-230215

Thoughts on trying something similar here? I could see grouping the options above into "View..." (personal preference over Visit) and "Block...", or keep the Visit actions exposed and just consolidate the Block actions (the way Boost does).

The biggest benefit is saving space while keeping taps minimal - and that space could eventually be used to add other options like Boost's menu has, such as reporting/sharing/saving/etc (if desired). Would love to hear your thoughts!

@micahmo
Copy link
Member Author

micahmo commented Dec 6, 2023

it might make sense to start consolidating similar actions

We can definitely work on optimizing the long-press menu. We already moved several options to the top row (imagine how big it would be if each of those were a separate row!). There are a couple approaches to take. Like Boost, we could group things by action. Sync takes a slightly different approach and groups things by entity (for example, you'd click on the person first, then you could block, visit, etc.).

It would be nice if we could minimize taps instead of requiring a second menu. At one point I tried putting secondary action buttons in the same row, like this (if you can picture what I mean). But it got a little too busy.

Actions
Visit Profile 🚫
Visit Community 🚫

Anyway, as usual, we can get this PR in first with the functionality, and then discuss a possible UI upgrade! If anyone wants to make mockups, that could help a lot!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I do like what @machinaeZER0 mentioned with regards to consolidating some actions.

I think one other alternative way to group things is to only show the most commonly accessed items on the initial bottom sheet modal. We can then have an "Others" section which opens up a sub-menu for other not as frequently used actions (similar to how the Sort -> Top options are implemented

For example, I'd imagine that blocking an instance or community from the comment long-press menu won't be used that frequently (whereas it would be more useful as actions on the feed/community pages)

Anyways, I'm up to any further ideas, and all the ones that have been mentioned so far makes sense to me too!

@hjiangsu hjiangsu merged commit 6061cc7 into thunder-app:develop Dec 6, 2023
1 check passed
@micahmo micahmo deleted the feature/actions branch December 6, 2023 17:29
@machinaeZER0
Copy link
Collaborator

For what it's worth, I actually primarily use the long press menu to block communities as I'm browsing the main feed, so I love that we currently have it exposed! Hear what you're saying though :)

@hjiangsu
Copy link
Member

hjiangsu commented Dec 6, 2023

Linking this issue as it relates to this: #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants