-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve comment/post actions #958
Conversation
We can definitely work on optimizing the long-press menu. We already moved several options to the top row (imagine how big it would be if each of those were a separate row!). There are a couple approaches to take. Like Boost, we could group things by action. Sync takes a slightly different approach and groups things by entity (for example, you'd click on the person first, then you could block, visit, etc.). It would be nice if we could minimize taps instead of requiring a second menu. At one point I tried putting secondary action buttons in the same row, like this (if you can picture what I mean). But it got a little too busy.
Anyway, as usual, we can get this PR in first with the functionality, and then discuss a possible UI upgrade! If anyone wants to make mockups, that could help a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I do like what @machinaeZER0 mentioned with regards to consolidating some actions.
I think one other alternative way to group things is to only show the most commonly accessed items on the initial bottom sheet modal. We can then have an "Others" section which opens up a sub-menu for other not as frequently used actions (similar to how the Sort -> Top options are implemented
For example, I'd imagine that blocking an instance or community from the comment long-press menu won't be used that frequently (whereas it would be more useful as actions on the feed/community pages)
Anyways, I'm up to any further ideas, and all the ones that have been mentioned so far makes sense to me too!
For what it's worth, I actually primarily use the long press menu to block communities as I'm browsing the main feed, so I love that we currently have it exposed! Hear what you're saying though :) |
Linking this issue as it relates to this: #253 |
Pull Request Description
This PR updates the Post and Comment actions to bring them more in parity with other functionality in the app and with each other.
Post - Added
Comment - Changed
Comment - Added
I also added a Block/Unblock Instance to the Visit Instance page (when supported).
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_3pRUbTl3oC.mp4
Checklist
semanticLabel
s where applicable for accessibility?