Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize current language #986

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 16, 2023

Pull Request Description

This PR detects if the current app language is in the list of allowed post languages, and if so, puts that language at the top (beneath "No language" and "Undetermined"). This should make it easier for users to create posts in their own language!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_jkviBzZjy0.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@hjiangsu hjiangsu merged commit 39213c5 into thunder-app:develop Jan 3, 2024
1 check passed
@micahmo micahmo deleted the feature/prioritize-language branch January 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants