Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share preview #987

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 16, 2023

This is a small PR which fixes an issue where the image preview in the advanced share sheet would always show "Unable to load image". The problem was that we would return the error text regardless of the state of the image viewer. However, this was only a problem for image viewers displaying bytes, not ones loading an image from a URL.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 8573971 into thunder-app:develop Dec 17, 2023
1 check passed
@micahmo micahmo deleted the fix/share-preview branch December 17, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants