Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too wide images in sidebars #990

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 18, 2023

This PR fixes an issue where images may be too wide in the sidebar. In #939 we removed the artificially enforced minimum size, which is still good, but now we also need an (optional) maximum size for constrained-width areas like the sidebar.

Before After
image image

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

lib/shared/image_preview.dart Outdated Show resolved Hide resolved
lib/community/widgets/community_sidebar.dart Outdated Show resolved Hide resolved
@micahmo micahmo requested a review from hjiangsu January 3, 2024 20:15
@micahmo micahmo requested a review from hjiangsu January 3, 2024 20:27
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :D

@hjiangsu hjiangsu merged commit 07b4aa5 into thunder-app:develop Jan 3, 2024
1 check passed
@micahmo micahmo deleted the fix/wide-images-sidebar branch January 3, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants