Feature/condensed post body

[micahmo]

Pull Request Description

This PR introduces a new view type for post bodies. Inspired by Relay, this allows the post body to be condensed, meaning that any link or image previews will remain as a small thumbnail on the side. Text posts are still fully expanded (and collapsible).

The use case here is that you've already viewed the image/link from the main feed, so now you want to jump right to the comments. Seeing the full image again is often unnecessary.

Note

I removed the duplicate "Show Cross Posts" setting from the General page, and made a new section on the Appearance > Posts page for post body settings.

P.S. If there is a better name than "Card View" for the default post body appearance, let me know!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_mGcC5dkilz.mp4

Checklist

• Did you update CHANGELOG.md?
• Did you use localized strings where applicable?
• Did you add semanticLabels where applicable for accessibility?

[hjiangsu]

Thanks for this, this is really cool!

I just have one discussion about architecture for this. Since we're starting to add new views to the post body, I'm thinking this is a good chance to make the setting as adaptable as possible to any potential future post view types. Instead of using useCompactPostBodyView, what are your thoughts on changing it to something more flexible like postBodyViewType?

Then, we can store an enum value (e.g., PostBodyViewType.condensed, or PostBodyViewType.mediaPreview) and use that to build this new view. The benefit here is that we are no longer restricted to using a boolean, so we can add in more variations of views to the post body (e.g., default could be PostBodyViewType.expanded, a future one could be something like PostBodyViewType.gallery, etc.).

I know I used useCompactView for the feed (which admittedly was not the best way to do it in hindsight 😅) which is why I wanted to bring it up! This is also something I eventually want to do with the feed view types as well so that we can add in more types of views (e.g., gallery view, etc).

[micahmo]

Instead of using useCompactPostBodyView, what are your thoughts on changing it to something more flexible like postBodyViewType?

Great idea! All done!

setting_refactor.mp4

[micahmo]

Sorry I slightly misunderstood your comment and I used condensed and mediaPreview as the two options. I just pushed another change to make the options condensed and expanded!

[hjiangsu]

LGTM! Thanks for changing it :D

I'll hold off on merging this until I get the 0.2.7 general release out