Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset search for empty query #999

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 20, 2023

This is a super small PR which restores a previous functionality. When the search field is empty, the search should be reset (i.e., no results shown). This works when pressing the x but was broken when deleting the contents of the search field.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit f38999a into thunder-app:develop Dec 20, 2023
1 check passed
@micahmo micahmo deleted the fix/reset-search branch December 20, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants