Change how we run migrations or initialize the database on a fresh installs #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelissaAutumn
force-pushed
the
features/119-clean-up-migration-process
branch
2 times, most recently
from
797089e
to
6bfa74f
Compare
MelissaAutumn
force-pushed
the
features/119-clean-up-migration-process
branch
from
2c8cf93
to
e7ba925
Compare
…119) - BREAKING: Added `appointment` module folder in `src`. - BREAKING: alembic.ini should now be placed in the backend root folder. You will need to grab a fresh copy as there's been additional changes. - Added a super simple cli interface handled by main.py - Adjusted main.py to bootstrap either a fast api server or a cli interface. - Added a `update-db` command that is installed when pip install this module. - The `update-db` command will initialize a fresh database or run migrations, resolving most of our database woes. - New folder structure more closely matches the deployed folder structure for easier deployments. - Local docker now only mounts the `src` folder - Commented out some non-existent columns/constraints in a recent migration - Added missing trailing slash to the frontend for `schedule/` - Added sentry support to migrations - Adjusted code-referenced folder locations as required
MelissaAutumn
force-pushed
the
features/119-clean-up-migration-process
branch
from
e7ba925
to
065857d
Compare
radishmouse
approved these changes
Oct 3, 2023
|
Neat, gonna merge it then. @devmount you might still want to get a look at it, since it's a big structure change 😅 |
devmount
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Hi @MelissaAutumn and @radishmouse, sorry I couldn't do a review earlier. First: Thanks Mel for this heavy PR done in such a short time 😮👏🏻 I've gone through the changes and completely reinstalled the application locally for testing:
- Installed Appointment via
docker-composewithout issues - Ran
update-dbwithout issues
- Appointment and Schedule creation in the frontend worked after relogin
So this is really great work, thank you!
One question: do we have to call all API endpoints with a trailing slash in the frontend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
This was a much bigger change than I expected. Most of it was due to how the aws deployment works, but it should be a-okay now.
There were some issues in one of the migration scripts as well, it was trying to drop columns that didn't exist. I uh, commented out the problem parts.
On the front-end side I discovered that if we declare a route like
@get('/')the frontend must include the slash at the end, otherwise fastapi will redirect, which causes issues to the nginx rewrite config. I couldn't find a good solution other than to just add slashes at the end of some of these calls.Changes:
BREAKING: Added
appointmentmodule folder insrc.BREAKING: alembic.ini should now be placed in the backend root folder. You will need to grab a fresh copy as there's been additional changes.
Added a super simple cli interface handled by main.py
Adjusted main.py to bootstrap either a fast api server or a cli interface.
Added a
update-dbcommand that is installed when pip install this module.The
update-dbcommand will initialize a fresh database or run migrations, resolving most of our database woes.New folder structure more closely matches the deployed folder structure for easier deployments.
Local docker now only mounts the
srcfolderCommented out some non-existent columns/constraints in a recent migration
Added missing trailing slash to the frontend for
schedule/Added sentry support to migrations
Adjusted code-referenced folder locations as required