Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar, contact, home, profile and settings page TypeScript #604

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

devmount
Copy link
Collaborator

@devmount devmount commented Aug 2, 2024

Description of the Change

This change adds types for the several pages and components, including calendar, contact, home, profile and settings pages.

  • The script section was moved to the top in the vue files
  • External connections store is now typed with explicitly supported providers
  • Several fixes and improvements including removal of deprecated code

Applicable Issues

Implements #413

Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few suggestions!

frontend/src/components/SettingsGeneral.vue Outdated Show resolved Hide resolved
frontend/src/views/CalendarView.vue Show resolved Hide resolved
Co-authored-by: Mel <97147377+MelissaAutumn@users.noreply.github.com>
@devmount devmount merged commit 8a747d3 into main Aug 7, 2024
4 checks passed
@devmount devmount deleted the enhancements/413-views-ts branch August 7, 2024 06:15
@devmount devmount self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants