Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTUE TypeScript #619

Merged
merged 8 commits into from
Sep 3, 2024
Merged

FTUE TypeScript #619

merged 8 commits into from
Sep 3, 2024

Conversation

devmount
Copy link
Collaborator

@devmount devmount commented Aug 29, 2024

Description of the Change

This change adds types for all FTUE components.

  • The script section was moved to the top in the vue files
  • Type errors from regressions got fixed
  • Type errors about mandatory/optional component properties got fixed
  • All deprecated definitions were moved or deleted

Applicable Issues

Closes #413
Closes #625

@devmount devmount self-assigned this Aug 29, 2024
Copy link

@aaspinwall aaspinwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a comment to improve readability

frontend/src/components/FTUE/SetupSchedule.vue Outdated Show resolved Hide resolved
frontend/tsconfig.json Show resolved Hide resolved
Copy link

@aaspinwall aaspinwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great!

@MelissaAutumn MelissaAutumn merged commit 6ebbcb7 into main Sep 3, 2024
4 checks passed
@MelissaAutumn MelissaAutumn deleted the enhancements/413-ftue-ts branch September 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync Calendars stuck on loading TSify the frontend
3 participants