Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap the :checked state to a v-model that applies on change event. #706

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

MelissaAutumn
Copy link
Member

Fixes #705

Originally we used state because v-model wasn't working. Now it works, so uhh. I moved it back.

@MelissaAutumn MelissaAutumn self-assigned this Oct 2, 2024
Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, v-model is indeed better here! Sorry that might have been me when switching to tbpro components 😬

@devmount devmount merged commit a556297 into main Oct 2, 2024
4 checks passed
@devmount devmount deleted the bugs/705-fix-generate-zoom-meeting-checkbox branch October 2, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Zoom Meeting checkbox does not restore state on page load
2 participants